Comments on: Longest Common Prefix Between Two Strings

By: aegrumet

aegrumet — Sat, 25 Jun 2011 09:14:10 +0000

Ah, thanks. I think it'll #fail on non-ascii, but it's a one-liner!

By: apokalyptik

apokalyptik — Sat, 25 Jun 2011 07:07:46 +0000

@aegrumet@alum.mit.edu You're right, weird. I edited it to chr(0) for you. Nice code

By: aegrumet@alum.mit.ed

aegrumet@alum.mit.ed — Sat, 25 Jun 2011 01:17:03 +0000

Hmm your software munged the code. The second argument to the ltrim should be "backslash zero".

By: aegrumet@alum.mit.ed

aegrumet@alum.mit.ed — Sat, 25 Jun 2011 01:16:01 +0000

How about:

function str_common_prefix( $s1, $s2 )

{

return strlen($s1^$s2)-strlen(ltrim($s1^$s2,chr(0)));

}

By: apokalyptik

apokalyptik — Sun, 05 Jun 2011 22:52:45 +0000

And, yes, I know I've said I hate the ternary operator… but I didn't set out to write the most beautiful version of this, just the shortest… I still believe that the ternary operator makes ugly and unreadable code, exemplified above.